> On Nov. 10, 2015, 7:25 p.m., Andreas Sandberg wrote: > > Hi! Thanks for contributing to gem5! > > > > Could you just remove the CC variable instead of changing it to CC? By > > doing so, you'll use the system's default compiler (cc in most cases) and > > you will be able to override it by setting CC on the command line. Also, > > please write a more descriptive commit message. See > > http://www.m5sim.org/Submitting_Contributions for details. I'd suggest > > using the misc keyword.
Thanks for the pointer. yes, you can just drop the line. Seems fine. - Bjoern A. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3195/#review7537 ----------------------------------------------------------- On Nov. 4, 2015, 2:36 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3195/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 2:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > With clang there are systems without "gcc" being installed anymore and we > should not rely on that. Use "cc" instead and make it compile on these > systems. > > > Diffs > ----- > > util/term/Makefile 2d1d51615e0e > > Diff: http://reviews.gem5.org/r/3195/diff/ > > > Testing > ------- > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
