http://reviews.gem5.org/r/2614/
On 20/11/2015, 17:29, "gem5-dev on behalf of Gutierrez, Anthony" <[email protected] on behalf of [email protected]> wrote: >I see these changes were pushed around Feb 2015, but can you point to the >rb posts? I am unable to find them in your history. > >-----Original Message----- >From: gem5-dev [mailto:[email protected]] On Behalf Of Andreas >Sandberg >Sent: Friday, November 20, 2015 8:36 AM >To: gem5 Developer List >Subject: Re: [gem5-dev] Style Checker: Includes Order Warning > >Joe, > >This is an unfortunate mis-match between the style checker and the wiki. >The style checker is right in this case. I have updated the wiki to >reflect this behavior. > >The reason for this new include order is that it ensures that header >files are independent. I.e., you¹ll never depend on the include order to >get a header to compile. > >//Andreas > >On 19/11/2015, 20:22, "gem5-dev on behalf of Gross, Joe" ><[email protected] on behalf of [email protected]> wrote: > >>Andreas, >> >>I'm running 11220:c0ea80fed78f, which should be the tip. It seems to >>happen after a qpush, which is a commit. >> >>Joe >> >>________________________________________ >>From: gem5-dev <[email protected]> on behalf of Andreas Hansson >><[email protected]> >>Sent: Thursday, November 19, 2015 2:33 AM >>To: gem5 Developer List >>Subject: Re: [gem5-dev] Style Checker: Includes Order Warning >> >>Hi Joe, >> >>This should be fixed (by Andreas Sandberg). Are you using an up-to-date >>repo? >> >>Andreas >> >>On 19/11/2015, 06:48, "gem5-dev on behalf of Gross, Joe" >><[email protected] on behalf of [email protected]> wrote: >> >>>Hello, >>> >>>When working with mq patches in the gem5 repo, I get a lot of warnings >>>about the order of includes being wrong. Although they follow the >>>guidelines set in the style guide, it seems that the script is looking >>>for something different. >>> >>>When directing the script to fix them, it will put the include for >>>XX.hh first if the file is XX.cc. It's unclear what causes this, but >>>several others have observed this behavior and have to choose ignore >>>many times in the course of applying patches. >>> >>>Is there some way to disable this portion of the style checker so that >>>we don't have to manually override it all the time? Thanks. >>> >>>Joe >>>_______________________________________________ >>>gem5-dev mailing list >>>[email protected] >>>http://m5sim.org/mailman/listinfo/gem5-dev >> >> >>________________________________ >> >>-- IMPORTANT NOTICE: The contents of this email and any attachments are >>confidential and may also be privileged. If you are not the intended >>recipient, please notify the sender immediately and do not disclose the >>contents to any other person, use it for any purpose, or store or copy >>the information in any medium. Thank you. >>_______________________________________________ >>gem5-dev mailing list >>[email protected] >>http://m5sim.org/mailman/listinfo/gem5-dev >>_______________________________________________ >>gem5-dev mailing list >>[email protected] >>http://m5sim.org/mailman/listinfo/gem5-dev > > >________________________________ > >-- IMPORTANT NOTICE: The contents of this email and any attachments are >confidential and may also be privileged. If you are not the intended >recipient, please notify the sender immediately and do not disclose the >contents to any other person, use it for any purpose, or store or copy >the information in any medium. Thank you. > >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev ________________________________ -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
