> On Dec. 1, 2015, 6:21 p.m., Nilay Vaish wrote: > > src/cpu/o3/probe/elastic_trace.cc, lines 917-922 > > <http://reviews.gem5.org/r/3089/diff/3/?file=51968#file51968line917> > > > > I am not completely sure, but for safety sake, are you allowed to > > return a reference here? What's the return type of > > Record::RecordType_Name()?
From the generated inst_dep_record.pb.h, the return type of RecordType_Name is const std::string& - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3089/#review7667 ----------------------------------------------------------- On Nov. 19, 2015, 5:20 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3089/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 5:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch replaces the booleans that specified the elastic trace record > type with an enum type. The source of change is the proto message for > elastic trace where the enum is introduced. The struct definitions in the > elastic trace probe listener as well as the Trace CPU replace the boleans > with the proto message enum. > > The patch does not impact functionality, but traces are not compatible with > previous version. This is preparation for adding new types of records in > subsequent patches. > > This patch adds to the "Elastic Traces" patch series of RB3026-3031. > > > Diffs > ----- > > src/cpu/o3/probe/elastic_trace.hh PRE-CREATION > src/cpu/o3/probe/elastic_trace.cc PRE-CREATION > src/cpu/trace/trace_cpu.hh PRE-CREATION > src/cpu/trace/trace_cpu.cc PRE-CREATION > src/proto/inst_dep_record.proto PRE-CREATION > util/decode_inst_dep_trace.py PRE-CREATION > util/encode_inst_dep_trace.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3089/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
