> On Dec. 4, 2015, 11:25 p.m., Nilay Vaish wrote: > > It seems there is something wrong with this patch. The pendingPacket > > variable belongs to > > LSQSenderState class and not LSQUnit whose constructor is being edited.
Actually I was mistaken. The patch is alright. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3241/#review7701 ----------------------------------------------------------- On Dec. 4, 2015, 11:11 a.m., Pau Cabre wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3241/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 11:11 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11240:59a46f1bb06d > --------------------------- > cpu: fix unitialized variable which may cause assertion failure > The assert in lsq_unit_impl.hh line 963 needs pktPending to be initialized > to NULL (I got the assertion failure several times without the fix). > > > Diffs > ----- > > src/cpu/o3/lsq_unit_impl.hh 3be64e1f80ed > > Diff: http://reviews.gem5.org/r/3241/diff/ > > > Testing > ------- > > > Thanks, > > Pau Cabre > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
