----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3254/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11262:68ccfc9951ea --------------------------- mem: Make cache terminology easier to understand This patch changes the name of a bunch of packet flags and MSHR member functions and variables to make the coherency protocol easier to understand. In addition the patch adds and updates lots of descriptions, explicitly spelling out assumptions. The following name changes are made: * the packet memInhibit flag is renamed to cacheResponding * the packet shared flag is renamed to passNonWritable * the packet NeedsExclusive attribute is renamed to NeedsWritable * the packet isSupplyExclusive is renamed responderHadWritable * the MSHR pendingDirty is renamed to pendingWritable The cache states, Modified, Owned, Exclusive, Shared are also called out in the cache and MSHR code to make it easier to understand. Diffs ----- src/cpu/o3/cpu.cc 8ed230a0b28c src/dev/dma_device.cc 8ed230a0b28c src/mem/abstract_mem.cc 8ed230a0b28c src/mem/addr_mapper.cc 8ed230a0b28c src/mem/bridge.cc 8ed230a0b28c src/mem/cache/base.hh 8ed230a0b28c src/mem/cache/blk.hh 8ed230a0b28c src/mem/cache/cache.hh 8ed230a0b28c src/mem/cache/cache.cc 8ed230a0b28c src/mem/cache/mshr.hh 8ed230a0b28c src/mem/cache/mshr.cc 8ed230a0b28c src/mem/cache/mshr_queue.hh 8ed230a0b28c src/mem/cache/mshr_queue.cc 8ed230a0b28c src/mem/coherent_xbar.cc 8ed230a0b28c src/mem/comm_monitor.cc 8ed230a0b28c src/mem/dram_ctrl.cc 8ed230a0b28c src/mem/dramsim2.cc 8ed230a0b28c src/mem/hmc_controller.cc 8ed230a0b28c src/mem/mem_checker_monitor.cc 8ed230a0b28c src/mem/noncoherent_xbar.cc 8ed230a0b28c src/mem/packet.hh 8ed230a0b28c src/mem/packet.cc 8ed230a0b28c src/mem/ruby/system/DMASequencer.cc 8ed230a0b28c src/mem/ruby/system/RubyPort.cc 8ed230a0b28c src/mem/serial_link.cc 8ed230a0b28c src/mem/simple_mem.cc 8ed230a0b28c src/mem/snoop_filter.cc 8ed230a0b28c src/mem/tport.cc 8ed230a0b28c Diff: http://reviews.gem5.org/r/3254/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
