> On Dec. 17, 2015, 5:46 p.m., Brad Beckmann wrote: > > src/sim/System.py, line 76 > > <http://reviews.gem5.org/r/3244/diff/1/?file=52126#file52126line76> > > > > Why make this default true? This changes the behavior of the simulator > > and now for those apps that are annotated with work_ends, the simulation > > stops as soon as the first annotation is encountered. Furthermore, it is > > not obvious that the simulation ends because the first annotation was > > encountered rather than the application reaches completion. > > > > Please revert back to the old behavior. It makes a lot more sense that > > by default, gem5 will execute the entire application and only stops > > prematurely if the user explicitly asks to exit when work items are > > encountered.
The intention was always to use the old behaviour by default. I'll push a fix shortly. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3244/#review7729 ----------------------------------------------------------- On Dec. 5, 2015, 12:29 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3244/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2015, 12:29 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11240:b7f2abdbce1a > --------------------------- > sim: Add an option to forward work items to Python > > There are cases where we want the Python world to handle work items > instead of the C++ world. However, that's currently not possible. This > changeset adds the forward_work_items option to the System class. Then > it is set to True, work items will generate workbegin/workend > simulation exists with the work item ID as the exit code and the old > C++ handling is completely bypassed. > > > Diffs > ----- > > src/sim/System.py 3be64e1f80ed > src/sim/pseudo_inst.cc 3be64e1f80ed > > Diff: http://reviews.gem5.org/r/3244/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
