-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3177/
-----------------------------------------------------------

(Updated Dec. 24, 2015, 10:51 a.m.)


Review request for Default.


Repository: gem5


Description (updated)
-------

Changeset 11276:4d4d9ba44808
---------------------------
ruby: slicc: have a static MachineType

This patch is imported from reviewboard patch 2551 by Nilay.
This patch moves from a dynamically defined MachineType to a statically
defined one.  The need for this patch was felt since a dynamically defined
type prevents us from having types for which no machine definition may
exist.

The following changes have been made:
i. each machine definition now uses a type from the MachineType enumeration
instead of any random identifier.  This required changing the grammar and the
*.sm files.
ii. MachineType enumeration defined statically in RubySlicc_Exports.sm.
* * *
normal protocol fixes for nilay's parser machine type fix


Diffs (updated)
-----

  src/mem/protocol/MESI_Three_Level-L1cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MESI_Three_Level-L0cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MI_example-dir.sm d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MI_example-cache.sm d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MESI_Two_Level-dma.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MESI_Two_Level-dir.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MESI_Two_Level-L2cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MESI_Two_Level-L1cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_directory-dir.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_directory-L2cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_directory-L1cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MI_example-dma.sm d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/slicc/symbols/SymbolTable.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/slicc/parser.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/slicc/ast/MachineAST.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/slicc/ast/DeclListAST.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/RubySlicc_Exports.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/Network_test-dir.sm d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/Network_test-cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_hammer-dma.sm d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_hammer-dir.sm d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_hammer-cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_token-dma.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_token-dir.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_token-L2cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_token-L1cache.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/protocol/MOESI_CMP_directory-dma.sm 
d9a0136ab8cc4b3cf4821d064140b857e60db0dd 
  src/mem/slicc/symbols/Type.py d9a0136ab8cc4b3cf4821d064140b857e60db0dd 

Diff: http://reviews.gem5.org/r/3177/diff/


Testing
-------


Thanks,

Tony Gutierrez

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to