----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3263/#review7789 -----------------------------------------------------------
Ship it! no need to repost on my behalf... src/mem/packet.hh (line 522) <http://reviews.gem5.org/r/3263/#comment6758> this comment should refer to hasSharers :) - Steve Reinhardt On Dec. 29, 2015, 8:16 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3263/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 8:16 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11287:7919581a74b4 > --------------------------- > mem: Do not rely on the NeedsWritable flag for responses > > This patch removes the NeedsWritable flag for all responses, as it is > really only the request that needs a writable response. The response, > on the other hand, should in these cases always provide the line in a > writable state, as indicated by the hasSharers flag not being set. > > When we send requests that has NeedsWritable set, the response will > always have the hasSharers flag not set. Additionally, there are cases > where the request did not have NeedsWritable set, and we still get a > writable response with the hasSharers flag not set. This never happens > on snoops, but is used by downstream caches to pass ownership > upstream. > > As part of this patch, the affected response types are updated, and > the snoop filter is similarly modified to check only the hasSharers > flag (as it should). A sanity check is also added to the packet class, > asserting that we never look at the NeedsWritable flag for responses. > > No regressions are affected. > > > Diffs > ----- > > src/mem/packet.hh 3fd1142adad9 > src/mem/packet.cc 3fd1142adad9 > src/mem/snoop_filter.cc 3fd1142adad9 > > Diff: http://reviews.gem5.org/r/3263/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
