----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3074/ -----------------------------------------------------------
(Updated Dec. 30, 2015, 6:28 p.m.) Review request for Default. Repository: gem5 Description (updated) ------- Changeset 11062:fbce13fdad11 --------------------------- sim: don't ignore SIG_TRAP By ignoring SIG_TRAP, using --debug-break <N> when not connected to a debugger becomes a no-op. Apparently this was intended to be a feature, though the rationale is not clear. If we don't ignore SIG_TRAP, then using --debug-break <N> when not connected to a debugger causes the simulation process to terminate at tick N. This is occasionally useful, e.g., if you just want to collect a trace for a specific window of execution then you can combine this with --debug-start to do exactly that. In addition to not ignoring the signal, this patch also updates the --debug-break help message and deletes a handful of unprotected calls to Debug::breakpoint() that relied on the prior behavior. Diffs ----- src/arch/alpha/ev5.cc 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db src/dev/net/ns_gige.cc 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db src/dev/net/sinic.cc 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db src/python/m5/main.py 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db src/sim/init_signals.cc 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db Diff: http://reviews.gem5.org/r/3074/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
