----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3267/#review7796 -----------------------------------------------------------
Ship it! Looks good to me. - Curtis Dunham On Dec. 31, 2015, 8:01 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3267/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 8:01 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11285:d2fbd02314de > --------------------------- > arch: don't call *Timing functions from *Atomic versions > > The readMemAtomic/writeMemAtomic helper functions were calling > readMemTiming/writeMemTiming respectively. This is functionally > correct, since the *Timing functions are doing the same access > initiation operation as the *Atomic functions (just that the > *Atomic versions also complete the access in line). It also > provides for some (very minimal) code reuse. Unfortunately, > it's potentially pretty confusing, since it makes it look like > the atomic accesses are somehow being converted to timing > accesses. It also gets in the way of specializing the timing > interface (as will be done in a future patch). > > > Diffs > ----- > > src/arch/generic/memhelpers.hh 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db > src/arch/x86/memhelpers.hh 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db > > Diff: http://reviews.gem5.org/r/3267/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
