----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3268/#review7800 -----------------------------------------------------------
Ship it! Technically o3 is not a keyword. I'd suggest to make it "cpu" and then get the "o3" part into the description. - Andreas Hansson On Dec. 31, 2015, 8:02 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3268/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 8:02 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11286:527ba63c15a9 > --------------------------- > o3: don't pass unnecessary data pointer to read() > > The read() function merely initiates a memory read operation; the > data doesn't arrive until the access completes and a response packet > is received from the memory system. Thus there's no need to provide > a data pointer; it's existence is historical. > > Getting this pointer out of this internal o3 interface sets the > stage for similar cleanup in the ExecContext interface. Also > found that we were pointlessly setting the contents at this pointer > on a store forward (the useful memcpy happens just a few lines > below the deleted one). > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db > src/cpu/o3/cpu.hh 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db > src/cpu/o3/lsq.hh 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db > src/cpu/o3/lsq_unit.hh 4cc8b312f026321a81cb0b043e8e3a5c20b5f5db > > Diff: http://reviews.gem5.org/r/3268/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
