> On Jan. 1, 2016, 2:51 p.m., Andreas Hansson wrote: > > I am a bit confused as the patch seems contain parts of the functionality > > needed to enable dirty bits per byte, but no write combining of uncacheable > > writes. The description definitely needs to be updated, and at the moment > > the diff also seems very incomplete.
Hi Andreas. You are correct, this patch adds functionality for ruby protocols to enable dirty bits per byte. It was developed to model write-combining caches in ruby. For example, see src/mem/protocol/GPU_VIPER-TCP.sm http://reviews.gem5.org/r/3189/diff/2/?page=7#35 src/mem/protocol/GPU_VIPER-TCC.sm http://reviews.gem5.org/r/3189/diff/2/?page=6#85 How about the following update the description: ruby: support for per-byte dirty bits. This patch enables ruby to model write-combining caches (e.g., GPU-Viper). - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3206/#review7806 ----------------------------------------------------------- On Nov. 12, 2015, 10:05 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3206/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 10:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11193:81764d4f4aa4 > --------------------------- > mem: write combining for ruby protocols > > This patch adds support for write-combining in ruby. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/RubyRequest.hh > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/common/WriteMask.cc PRE-CREATION > src/mem/ruby/common/WriteMask.hh PRE-CREATION > src/mem/ruby/common/SConscript 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/SConscript 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/common/DataBlock.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/common/DataBlock.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/protocol/RubySlicc_Exports.sm > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/protocol/RubySlicc_Types.sm > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3206/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
