----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3265/#review7938 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Dec. 30, 2015, 11:11 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3265/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 11:11 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11291:a6168c5472d6 > --------------------------- > mem: Align how snoops are handled when hitting writebacks > > This patch unifies the snoop handling in case of hitting writebacks > with how we handle snoops hitting in the tags. As a result, we end up > using the same optimisation as the normal snoops, where we inform the > downstream cache if we encounter a line in Modified (writable and > dirty) state, which enables us to avoid sending out express snoops to > invalidate any Shared copies of the line. A few regressions > consequently change, as some transactions are sunk higher up in the > cache hierarchy. > > > Diffs > ----- > > src/mem/cache/cache.cc 4cc8b312f026 > > Diff: http://reviews.gem5.org/r/3265/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
