----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3299/#review7964 -----------------------------------------------------------
Ship it! Looks good to me. A couple of minor issues below. util/style.py (line 351) <http://reviews.gem5.org/r/3299/#comment6935> IIRC, the Python style guide (PEP-0008) prescribes that opening and closing brackets for multi-line lists should be on their own lines. util/style.py (line 593) <http://reviews.gem5.org/r/3299/#comment6934> -f probably shouldn't be short for --ign-all. Also, could you rename these to --ignore-XX instead of --ign-XX? It's slightly longer, but would be closer to the naming convention for other (HG) options. - Andreas Sandberg On Jan. 26, 2016, 9:24 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3299/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 9:24 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11311:8d2efdba4dae > --------------------------- > util: clean up and extend style checker > > Added a new Verifier object to check for and fix spacing > between if/while/for and following paren. > > Restructured Verifier class to make it easier to add > new subclasses, particularly by using a global list of > verifiers to auto-generate command line options and > simplify the invocation loop. > > > Diffs > ----- > > util/style.py 9be8a40026dfa419c3daf572407f9391ad48e1ed > > Diff: http://reviews.gem5.org/r/3299/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
