-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3308/
-----------------------------------------------------------
Review request for Default.
Repository: gem5
Description
-------
Changeset 11321:42f3fc1ea44c
---------------------------
style: eliminate explicit boolean comparisons
Result of running 'hg m5style --skip-all --fix-control -a' to get
rid of '== true' comparisons, plus trivial manual edits to get
rid of '== false'/'== False' comparisons.
Left a couple of explicit comparisons in where they didn't seem
unreasonable:
invalid boolean comparison in src/arch/mips/interrupts.cc:155
>> DPRINTF(Interrupt, "Interrupts OnCpuTimerINterrupt(tc) == true\n");<<
invalid boolean comparison in src/unittest/unittest.hh:110
>> "EXPECT_FALSE(" #expr ")", (expr) == false)<<
Diffs
-----
src/arch/hsail/gen.py 89fd4a775287e4fcb1313f12ef16d426971f615a
src/arch/hsail/insts/decl.hh 89fd4a775287e4fcb1313f12ef16d426971f615a
src/arch/hsail/insts/mem.hh 89fd4a775287e4fcb1313f12ef16d426971f615a
src/cpu/base.cc 89fd4a775287e4fcb1313f12ef16d426971f615a
src/dev/net/dist_iface.cc 89fd4a775287e4fcb1313f12ef16d426971f615a
src/mem/ruby/common/WriteMask.hh 89fd4a775287e4fcb1313f12ef16d426971f615a
src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc
89fd4a775287e4fcb1313f12ef16d426971f615a
src/mem/ruby/system/GPUCoalescer.cc 89fd4a775287e4fcb1313f12ef16d426971f615a
src/mem/slicc/symbols/Transition.py 89fd4a775287e4fcb1313f12ef16d426971f615a
Diff: http://reviews.gem5.org/r/3308/diff/
Testing
-------
Thanks,
Steve Reinhardt
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
