----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3302/#review7969 -----------------------------------------------------------
Ship it! Seems reasonable. Could you please line wrap the patch description, though? - Joel Hestness On Jan. 29, 2016, 11:58 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3302/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 11:58 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Due to insufficient build deps, the checkpoint tags might not get updated; > this patch solves this. Due to the uncommon nature of the build target, > regenerating tags.cc is a fairly clean solution. Since SCons hashes file > contents, it won't recompile anything unless a new checkpoint upgrader is > actually added. > > > Diffs > ----- > > src/SConscript 4a5f52f2defa7a3c0ed2a273a62d266f9d30acc8 > > Diff: http://reviews.gem5.org/r/3302/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
