> On Jan. 28, 2016, 9:27 p.m., Michael LeBeane wrote: > > Does anybody have any feedback for this patch? If not, we will check it in > > next Wednesday (02/03). > > Andreas Hansson wrote: > Could someone please explain what the reason for the initial change was? > It seems odd to revert this without getting to the bottom of the _reason_ for > the initial modification (and why it has changed). > > Michael LeBeane wrote: > Sure, I probably should have given some more context initially. The > reasoning for the initial change can be found here: > http://reviews.gem5.org/r/2208/. To summarize, Nilay wanted to remove > functionality specific to the CPU from the DMASequencer. > > A discussion on why we want to change it back can be found here: > http://reviews.gem5.org/r/3134/. To summarize, we have internal devices > which need the DMASequencer to be able to communicate on the PIO bus. This > feature was removed in Nilay's original patch. In the discussion, Nilay > approves rolling back his original changes. > > Andreas Hansson wrote: > It would be great to have Nilay's input on this patch...
I don't think that Nilay has been active on Review Board for a few months. I plan on pushing this on 02/11 if he doesn't respond. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3281/#review7966 ----------------------------------------------------------- On Jan. 15, 2016, 8:14 p.m., Michael LeBeane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3281/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 8:14 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11298:4ef93e72a8a8 > --------------------------- > ruby: make DMASequencer inherit from RubyPort > > This patch essentially rolls back 10518:30e3715c9405 to make RubyPort the > parent class of DMASequencer. It removes redundant code and restores some > features which were lost when directly inheriting from MemObject. For > example, > DMASequencer can now communicate to other devices using PIO, which is useful > for memmory-mapped communication between multiple DMADevices. > > > Diffs > ----- > > src/mem/ruby/system/DMASequencer.hh > d1f8610cdffd798144fe78f6fd904b8c983f6056 > src/mem/ruby/system/DMASequencer.cc > d1f8610cdffd798144fe78f6fd904b8c983f6056 > src/mem/ruby/system/Sequencer.py d1f8610cdffd798144fe78f6fd904b8c983f6056 > > Diff: http://reviews.gem5.org/r/3281/diff/ > > > Testing > ------- > > > Thanks, > > Michael LeBeane > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
