----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3316/ -----------------------------------------------------------
(Updated Feb. 10, 2016, 12:31 a.m.) Review request for Default. Repository: gem5 Description (updated) ------- cpu: Fix LLSC atomic CPU wakeup Writes to locked memory addresses (LLSC) did not wake up the locking CPU. This can lead to deadlocks on multi-core runs. In AtomicSimpleCPU, recvAtomicSnoop was checking if the incoming packet was an invalidation (isInvalidate) and only then handled a locked snoop. But, writes are seen instead of invalidates when running without caches (fast-forward configurations). As as simple fix, now handleLockedSnoop is also called even if the incoming snoop packet are from writes. Tests, Ran regression on all ISAs, observed acceptable change in 1: opt/quick/fs/10.linux-boot/arm/linux/realview-simple-timing-dual Diffs ----- src/cpu/minor/lsq.cc c2146e4e20cd30c35b7ff4f4cd15c953663cdc4d src/cpu/simple/atomic.cc c2146e4e20cd30c35b7ff4f4cd15c953663cdc4d src/cpu/simple/timing.cc c2146e4e20cd30c35b7ff4f4cd15c953663cdc4d Diff: http://reviews.gem5.org/r/3316/diff/ Testing ------- Thanks, Curtis Dunham _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
