----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3273/#review8016 -----------------------------------------------------------
Ship it! John, I've been using this internally and have even made some modifications to my own branch using the same API calls and it all works just fine. - Joe Gross On Feb. 16, 2016, 9:56 a.m., John Kalamatianos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3273/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 9:56 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11342:3a8eb18b522f > --------------------------- > gpu: parametrize Wavefront size > Eliminate VSZ constant that defined the Wavefront size in numbers of work > items. Replaced it with a parameter in the GPU.py configuration script. > Changed all data structures dependent on the Wavefront size to be > dynamically sized. > Legal values of Wavefront size are 16, 32, 64 for now and checked at > initialization time. > > Updated the patch so that it builds with latest version of Gem5. > > > Diffs > ----- > > src/gpu-compute/wavefront.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/wavefront.cc bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > configs/example/apu_se.py bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/gen.py bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/insts/branch.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/insts/main.cc bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/insts/mem.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/insts/mem_impl.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/insts/pseudo_inst.cc > bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/arch/hsail/operand.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/GPU.py bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/cl_driver.cc bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/compute_unit.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/compute_unit.cc bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/dispatcher.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/dispatcher.cc bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/global_memory_pipeline.cc > bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/gpu_dyn_inst.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/gpu_dyn_inst.cc bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/local_memory_pipeline.cc > bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/misc.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/qstruct.hh bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/vector_register_file.cc > bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/vector_register_state.hh > bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > src/gpu-compute/vector_register_state.cc > bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > > Diff: http://reviews.gem5.org/r/3273/diff/ > > > Testing > ------- > > > Thanks, > > John Kalamatianos > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
