Hi Tony, Thanks for taking a look at the regression problem. I'm a little confused about this fix though: The sendRangeChange() call was originally in the DMASequencer, but not in the RubyPort. Here, you've added it in the RubyPort. Shouldn't this have been put back into DMASequencer::init() instead?
Thanks! Joel On Wed, Feb 17, 2016 at 10:32 AM, Tony Gutierrez <[email protected]> wrote: > changeset e777659dcff6 in /z/repo/gem5 > details: http://repo.gem5.org/gem5?cmd=changeset;node=e777659dcff6 > description: > ruby: send address ranges from RubyPort > > diffstat: > > src/mem/ruby/system/RubyPort.cc | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diffs (13 lines): > > diff -r a4d19e7cd26d -r e777659dcff6 src/mem/ruby/system/RubyPort.cc > --- a/src/mem/ruby/system/RubyPort.cc Wed Feb 17 03:56:20 2016 -0500 > +++ b/src/mem/ruby/system/RubyPort.cc Wed Feb 17 11:31:54 2016 -0500 > @@ -84,6 +84,9 @@ > { > assert(m_controller != NULL); > m_mandatory_q_ptr = m_controller->getMandatoryQueue(); > + > + for (const auto &s_port : slave_ports) > + s_port->sendRangeChange(); > } > > BaseMasterPort & > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > -- Joel Hestness PhD Candidate, Computer Architecture Dept. of Computer Science, University of Wisconsin - Madison http://pages.cs.wisc.edu/~hestness/ _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
