> On Feb. 23, 2016, 2:54 p.m., Jason Lowe-Power wrote: > > src/arch/hsail/insts/mem_impl.hh, line 245 > > <http://reviews.gem5.org/r/3337/diff/1/?file=53814#file53814line245> > > > > if (mask[lane] && m->addr[lane] < w->privSizePerItem)? > > > > Or am I missing something here?
Sure..., I can move the nested if into the first-level if. Doesn't make much difference to me :-). - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/#review8023 ----------------------------------------------------------- On Feb. 23, 2016, 12:39 a.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3337/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2016, 12:39 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11348:01a0e9fbaad4 > --------------------------- > gpu-compute: fix uninitialized value error. > > I came across this uninitialized value error, while running the gpu-compute > model inside valgrind. > > > Diffs > ----- > > src/arch/hsail/insts/mem_impl.hh 64e862d3758f20730c25961e0bbefb1123be4fec > > Diff: http://reviews.gem5.org/r/3337/diff/ > > > Testing > ------- > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
