----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3353/#review8045 -----------------------------------------------------------
Ship it! Well, this is a nice feature I wish I'd known about for the past... 5 years. - Jason Lowe-Power On Feb. 26, 2016, 12:56 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3353/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 12:56 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11345:f7caf45f2bd5 > --------------------------- > scons: fix building in non-standard locations > > It's apparently not widely known that our scons scripts allow you to > put the build directory wherever you want; not only does it not have > to be immediately under the root of your repo, it doesn't even have > to be underneath the root at all. (For example, sometimes it's useful > to build on a local disk if your repo is on a slow NFS mount.) > > I point this out because this functionality has been broken for close > to two years but no one seems to have noticed yet. This patch fixes > an assumption that crept in in changeset be0e1724eb39 (May 09 2014) > that the build dir would be immediately under the top level of the > repo, preventing builds anywhere else. > > > Diffs > ----- > > src/SConscript bda2c39fd9fdcedbe7a4b1df38f9ac1279208eee > > Diff: http://reviews.gem5.org/r/3353/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
