> On Feb. 29, 2016, 7:02 p.m., Jason Lowe-Power wrote: > > What is it about the GPU protocols that's different from all the other > > protocols? > > > > Also, does this mean that you can't use the DRAMCtrl with with GPU > > protocols anymore? I personally always use the DRAMCtrl instead of the Ruby > > memory controller. In fact, I think it's default for all other protocols.
Nothing particularly special, but the current queueMemory calls really have no way to fail and simply push requests into the QueuedMasterPort. With GPU applications I found it to be much easier to find cases that fill the port's internal packet_queue and trigger an assertion if the size grows larger than 100 packets. If these function calls are being removed, this change will also need to be applied to the CPU protocols, but i'd like to get a consensus between you, Joel, and others before spending time updating those. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3355/#review8050 ----------------------------------------------------------- On Feb. 29, 2016, 6:50 p.m., Matthew Poremba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3355/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 6:50 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11355:02756e2f2053 > --------------------------- > ruby: Replace queueMemory calls with MessageBuffer enqueues in GPU protocols > > Calls to queueMemoryRead and queueMemoryWrite are removed in a previous > patch. This patch replaces these calls with enqueues to a MessageBuffer > which provides flow control to the directories. This modifies all GPU > protocols to use the new interface. > > > Diffs > ----- > > configs/ruby/GPU_RfO.py 31c5786945b447b372c3b7d346aea8fa6208577c > configs/ruby/GPU_VIPER.py 31c5786945b447b372c3b7d346aea8fa6208577c > configs/ruby/GPU_VIPER_Baseline.py 31c5786945b447b372c3b7d346aea8fa6208577c > configs/ruby/GPU_VIPER_Region.py 31c5786945b447b372c3b7d346aea8fa6208577c > src/mem/protocol/MOESI_AMD_Base-Region-dir.sm > 31c5786945b447b372c3b7d346aea8fa6208577c > src/mem/protocol/MOESI_AMD_Base-dir.sm > 31c5786945b447b372c3b7d346aea8fa6208577c > src/mem/protocol/MOESI_AMD_Base-probeFilter.sm > 31c5786945b447b372c3b7d346aea8fa6208577c > src/mem/protocol/RubySlicc_MemControl.sm > 31c5786945b447b372c3b7d346aea8fa6208577c > > Diff: http://reviews.gem5.org/r/3355/diff/ > > > Testing > ------- > > > Thanks, > > Matthew Poremba > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
