----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3335/#review8055 -----------------------------------------------------------
I looked a this a little too closely, I think. configs/dram/lat_mem_rd.py (line 165) <http://reviews.gem5.org/r/3335/#comment6966> Not a big deal, but you can remove the assumed tick rate with fromSeconds(toLatency('150ns')) IIRC. configs/dram/lat_mem_rd.py (line 185) <http://reviews.gem5.org/r/3335/#comment6967> Again, it would be nice if this wasn't hard coded. Also, shouldn't it have 3 more 0s? to make it 10^12 (1 ps is the default tick rate, right)? - Jason Lowe-Power On Feb. 15, 2016, 9:01 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3335/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 9:01 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11338:0b53da5fbb22 > --------------------------- > configs: Add a lat_mem_rd style test script > > This patch adds a config script that broadly replicates the behaviour > of lat_mem_rd. The test is based on traffic generators, and as such we > simply randomise addresses in increasingly large ranges, and play them > back using the trace functionality of the traffic generator. > > The test script is accompanied by a post-processing and visualisation > script. At the moment no configurability is added to tweak the memory > hierarchy, but a follow on patch could easily extend the > functionality. > > > Diffs > ----- > > configs/dram/lat_mem_rd.py PRE-CREATION > util/dram_lat_mem_rd_plot.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3335/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
