----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3346/#review8086 -----------------------------------------------------------
Ship it! Thanks a bunch for all your patience and flexibility!!! - Steve Reinhardt On March 15, 2016, 11:24 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3346/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 11:24 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11369:5164e22ac2fb > --------------------------- > mem: Create a separate class for the cache write buffer > > This patch breaks out the cache write buffer into a separate class, > without affecting any stats. The goal of the patch is to avoid > encumbering the much-simpler write queue with the complex MSHR > handling. In a follow on patch this simplification allows us to > implement write combining. > > The WriteQueue gets its own class, but shares a common ancestor, the > generic Queue, with the MSHRQueue. > > > Diffs > ----- > > src/mem/cache/SConscript 2fd64ea0a7cb > src/mem/cache/base.hh 2fd64ea0a7cb > src/mem/cache/base.cc 2fd64ea0a7cb > src/mem/cache/cache.hh 2fd64ea0a7cb > src/mem/cache/cache.cc 2fd64ea0a7cb > src/mem/cache/mshr.hh 2fd64ea0a7cb > src/mem/cache/mshr.cc 2fd64ea0a7cb > src/mem/cache/mshr_queue.hh 2fd64ea0a7cb > src/mem/cache/mshr_queue.cc 2fd64ea0a7cb > src/mem/cache/queue.hh PRE-CREATION > src/mem/cache/queue_entry.hh PRE-CREATION > src/mem/cache/write_queue.hh PRE-CREATION > src/mem/cache/write_queue.cc PRE-CREATION > src/mem/cache/write_queue_entry.hh PRE-CREATION > src/mem/cache/write_queue_entry.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3346/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
