----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3379/#review8087 -----------------------------------------------------------
Ship it! I'm a bit surprised that this assert triggers -- in most cases, we shuldn't call the probes unless there is an event happening. I can see how it would be useful to be able to add 0 since it potentially means that PMU hooks can be a bit cleaner. - Andreas Sandberg On March 15, 2016, 5:02 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3379/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 5:02 p.m.) > > > Review request for Default and Andreas Sandberg. > > > Repository: gem5 > > > Description > ------- > > arm,dev: remove PMU assertion hit on reset > > Remve the assertion that we always need to add a delta larger than > zero as that does not seem to be true when we hit it in the > "PMU reset cycle counter to zero" case. > > > Diffs > ----- > > src/arch/arm/pmu.cc 2fd64ea0a7cb > > Diff: http://reviews.gem5.org/r/3379/diff/ > > > Testing > ------- > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
