----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3376/#review8089 -----------------------------------------------------------
Ship it! Looks fine to me. Could you make sure that this doesn't break Linux? (I assume you have mainly tested with *BSD.) - Andreas Sandberg On March 15, 2016, 4:59 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3376/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 4:59 p.m.) > > > Review request for Default and Andreas Sandberg. > > > Repository: gem5 > > > Description > ------- > > arm,dev: PL011 UART_FR read status enhancement > > Given we do not simulate a FIFO currently there are only two states > we can be in upon read: empty or full. Properly signal the latter. > > Add and sort constants for states in the header file. > > > Diffs > ----- > > src/dev/arm/pl011.hh 2fd64ea0a7cb > src/dev/arm/pl011.cc 2fd64ea0a7cb > > Diff: http://reviews.gem5.org/r/3376/diff/ > > > Testing > ------- > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
