Hi Everyone, I have a handful of style checker fixes that lead up to a style checker we can use as a git hook. The changes can roughly be split into three groups: 1) cleanup existing scripts, 2) refactor the style script(s) to allow better code reuse, and 3) add git helpers. Group 1 is potentially disruptive since it changes the name of a script that is typically imported by Mercurial. I¹d really appreciate a speedy review of that since I don¹t want to commit that change to our internal integration branch until we know we can commit it upstream as well. Ideally, I¹d like to be able to commit it next week.
The first two patches are fairly straight-forward and prepare the existing style checker for a rewrite. The biggest change is that I need to rename style.py to hgstyle.py. This is for two reasons: 1) style.py suggests that it is a generic script that can be run to check style. It isn¹t. It¹s a library/plugin that should be called from Mercurial as a hook or a command (hg m5style). 2) Mercurial¹s plugin loader gets confused when there is both a module and a package called style. style: Remove unsupported style.py commands [1] scons, style: Rename style.py to hgstyle.py [2] The remaining changes factor out style checker functionality from the Mercurial plugin and implement a simple style checker script that can be run without Mercurial: style: Change include sorter to yield one line at a time [3] style: Refactor the style checker as a Python package [4] style: Add repository helper functions [5] style: Add a style checker that doesn't depend on Mercurial [6] Git support is added by these changes: style: Add a git pre-commit hook [7] scons: Automatically install the git style hook [8] Thanks, Andreas [1] http://reviews.gem5.org/r/3380/ [2] http://reviews.gem5.org/r/3381/ [3] http://reviews.gem5.org/r/3382/ [4] http://reviews.gem5.org/r/3383/ [5] http://reviews.gem5.org/r/3384/ [6] http://reviews.gem5.org/r/3387/ [7] http://reviews.gem5.org/r/3385/ [8] http://reviews.gem5.org/r/3386/ IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
