Hi Steve,
I suspect that is the whole list.
Andreas
On 24/03/2016, 13:40, "gem5-dev on behalf of Steve Reinhardt"
<gem5-dev-boun...@gem5.org on behalf of ste...@gmail.com> wrote:
>Alternatively, if it's easier for you to just construct a list of the
>flags
>that you've seen show up as undefined on the platforms you compile on, we
>can add the ifdefs ourselves and commit it, though we'd still only be able
>to test on the same set of platforms as before. Shouldn't break anything,
>we'd just be unable to verify whether the list you provided was complete.
>
>Steve
>
>
>On Thu, Mar 24, 2016 at 6:35 AM Steve Reinhardt <ste...@gmail.com> wrote:
>
>> Sorry. We tested extensively on the set of platforms that are available
>> to us, but those are all Linux variants.
>>
>> Clearly it's just a matter of referencing OS flags that are undefined
>>on a
>> particular platform, and all that needs to be done is to take the
>>offending
>> { OS::TGT_OS_FLAG, OS_FLAG }
>> and wrap it in an #ifdef OS_FLAG / #endif pair (as is already done for
>>the
>> set of flags that we've run into trouble with elsewhere).
>>
>> While we could do this ourselves based on the error listing you
>>provided,
>> we'd still be unable to test on the platforms you're having trouble
>>with,
>> so I think it would be far faster and more efficient if you'd be
>>willing to
>> put those ifdefs in. We'd really appreciate your cooperation.
>>
>> In case it's helpful, here's a quick xemacs macro that will wrap the
>>next
>> line after the cursor for you:
>> (setq last-kbd-macro (read-kbd-macro
>> "C-s ::TGT_ C-SPC C-s , <left> C-x C-x M-w C-a #ifdef SPC C-y RET C-e
>>RET
>> #endif"))
>>
>> Thanks,
>>
>> Steve
>>
>>
>> On Thu, Mar 24, 2016 at 2:52 AM Andreas Hansson
>><andreas.hans...@arm.com>
>> wrote:
>>
>>> Hi all (and Brandon in particular),
>>>
>>> Unfortunately http://repo.gem5.org/gem5/rev/5ac090acd180 causes build
>>> issues on OSX and even certain Linux systems (with older kernels, and
>>>also
>>> specific kernel configurations).
>>>
>>> Brandon, could you either back this out, or find some alternative
>>> solution to this problem? The sooner the better.
>>>
>>> See below for an example of the issues on OSX.
>>>
>>> Thanks,
>>>
>>> Andreas
>>>
>>> —————————————————————————————————
>>>
>>> build/ARM/arch/arm/linux/linux.cc:109:35: error: use of undeclared
>>> identifier
>>> 'O_NOATIME'
>>> { ArmLinux32::TGT_O_NOATIME, O_NOATIME },
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:122:46: error: invalid application of
>>> 'sizeof'
>>> to an incomplete type 'SyscallFlagTransTable []'
>>> const int ArmLinux32::NUM_OPEN_FLAGS =
>>>sizeof(ArmLinux32::openFlagTable) /
>>>
>>>^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> build/ARM/arch/arm/linux/linux.cc:130:37: error: use of undeclared
>>> identifier
>>> 'MAP_DENYWRITE'; did you mean 'TGT_MAP_DENYWRITE'?
>>> { ArmLinux32::TGT_MAP_DENYWRITE, MAP_DENYWRITE },
>>> ^~~~~~~~~~~~~
>>> TGT_MAP_DENYWRITE
>>> build/ARM/arch/arm/linux/linux.hh:133:27: note: 'TGT_MAP_DENYWRITE'
>>> declared
>>> here
>>> static const unsigned TGT_MAP_DENYWRITE = 0x00800;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:131:37: error: use of undeclared
>>> identifier
>>> 'MAP_EXECUTABLE'; did you mean 'TGT_MAP_EXECUTABLE'?
>>> { ArmLinux32::TGT_MAP_EXECUTABLE, MAP_EXECUTABLE },
>>> ^~~~~~~~~~~~~~
>>> TGT_MAP_EXECUTABLE
>>> build/ARM/arch/arm/linux/linux.hh:134:27: note: 'TGT_MAP_EXECUTABLE'
>>> declared
>>> here
>>> static const unsigned TGT_MAP_EXECUTABLE = 0x01000;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:133:37: error: use of undeclared
>>> identifier
>>> 'MAP_GROWSDOWN'; did you mean 'TGT_MAP_GROWSDOWN'?
>>> { ArmLinux32::TGT_MAP_GROWSDOWN, MAP_GROWSDOWN },
>>> ^~~~~~~~~~~~~
>>> TGT_MAP_GROWSDOWN
>>> build/ARM/arch/arm/linux/linux.hh:136:27: note: 'TGT_MAP_GROWSDOWN'
>>> declared
>>> here
>>> static const unsigned TGT_MAP_GROWSDOWN = 0x00100;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:134:37: error: use of undeclared
>>> identifier
>>> 'MAP_HUGETLB'
>>> { ArmLinux32::TGT_MAP_HUGETLB, MAP_HUGETLB },
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:135:37: error: use of undeclared
>>> identifier
>>> 'MAP_LOCKED'
>>> { ArmLinux32::TGT_MAP_LOCKED, MAP_LOCKED },
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:136:37: error: use of undeclared
>>> identifier
>>> 'MAP_NONBLOCK'; did you mean 'TGT_MAP_NONBLOCK'?
>>> { ArmLinux32::TGT_MAP_NONBLOCK, MAP_NONBLOCK },
>>> ^~~~~~~~~~~~
>>> TGT_MAP_NONBLOCK
>>> build/ARM/arch/arm/linux/linux.hh:139:27: note: 'TGT_MAP_NONBLOCK'
>>> declared here
>>> static const unsigned TGT_MAP_NONBLOCK = 0x10000;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:138:37: error: use of undeclared
>>> identifier
>>> 'MAP_POPULATE'; did you mean 'TGT_MAP_POPULATE'?
>>> { ArmLinux32::TGT_MAP_POPULATE, MAP_POPULATE },
>>> ^~~~~~~~~~~~
>>> TGT_MAP_POPULATE
>>> build/ARM/arch/arm/linux/linux.hh:141:27: note: 'TGT_MAP_POPULATE'
>>> declared here
>>> static const unsigned TGT_MAP_POPULATE = 0x08000;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:147:15: error: invalid application of
>>> 'sizeof'
>>> to an incomplete type 'SyscallFlagTransTable []'
>>> sizeof(ArmLinux32::mmapFlagTable) /
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> build/ARM/arch/arm/linux/linux.cc:210:35: error: use of undeclared
>>> identifier
>>> 'O_NOATIME'
>>> { ArmLinux64::TGT_O_NOATIME, O_NOATIME },
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:223:46: error: invalid application of
>>> 'sizeof'
>>> to an incomplete type 'SyscallFlagTransTable []'
>>> const int ArmLinux64::NUM_OPEN_FLAGS =
>>>sizeof(ArmLinux64::openFlagTable) /
>>>
>>>^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> build/ARM/arch/arm/linux/linux.cc:231:37: error: use of undeclared
>>> identifier
>>> 'MAP_DENYWRITE'; did you mean 'TGT_MAP_DENYWRITE'?
>>> { ArmLinux64::TGT_MAP_DENYWRITE, MAP_DENYWRITE },
>>> ^~~~~~~~~~~~~
>>> TGT_MAP_DENYWRITE
>>> build/ARM/arch/arm/linux/linux.hh:345:27: note: 'TGT_MAP_DENYWRITE'
>>> declared
>>> here
>>> static const unsigned TGT_MAP_DENYWRITE = 0x00800;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:232:37: error: use of undeclared
>>> identifier
>>> 'MAP_EXECUTABLE'; did you mean 'TGT_MAP_EXECUTABLE'?
>>> { ArmLinux64::TGT_MAP_EXECUTABLE, MAP_EXECUTABLE },
>>> ^~~~~~~~~~~~~~
>>> TGT_MAP_EXECUTABLE
>>> build/ARM/arch/arm/linux/linux.hh:346:27: note: 'TGT_MAP_EXECUTABLE'
>>> declared
>>> here
>>> static const unsigned TGT_MAP_EXECUTABLE = 0x01000;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:234:37: error: use of undeclared
>>> identifier
>>> 'MAP_GROWSDOWN'; did you mean 'TGT_MAP_GROWSDOWN'?
>>> { ArmLinux64::TGT_MAP_GROWSDOWN, MAP_GROWSDOWN },
>>> ^~~~~~~~~~~~~
>>> TGT_MAP_GROWSDOWN
>>> build/ARM/arch/arm/linux/linux.hh:348:27: note: 'TGT_MAP_GROWSDOWN'
>>> declared
>>> here
>>> static const unsigned TGT_MAP_GROWSDOWN = 0x00100;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:235:37: error: use of undeclared
>>> identifier
>>> 'MAP_HUGETLB'
>>> { ArmLinux64::TGT_MAP_HUGETLB, MAP_HUGETLB },
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:236:37: error: use of undeclared
>>> identifier
>>> 'MAP_LOCKED'
>>> { ArmLinux64::TGT_MAP_LOCKED, MAP_LOCKED },
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:237:37: error: use of undeclared
>>> identifier
>>> 'MAP_NONBLOCK'; did you mean 'TGT_MAP_NONBLOCK'?
>>> { ArmLinux64::TGT_MAP_NONBLOCK, MAP_NONBLOCK },
>>> ^~~~~~~~~~~~
>>> TGT_MAP_NONBLOCK
>>> build/ARM/arch/arm/linux/linux.hh:351:27: note: 'TGT_MAP_NONBLOCK'
>>> declared here
>>> static const unsigned TGT_MAP_NONBLOCK = 0x10000;
>>> ^
>>> build/ARM/arch/arm/linux/linux.cc:239:37: error: use of undeclared
>>> identifier
>>> 'MAP_POPULATE'; did you mean 'TGT_MAP_POPULATE'?
>>> { ArmLinux64::TGT_MAP_POPULATE, MAP_POPULATE },
>>> ^~~~~~~~~~~~
>>> TGT_MAP_POPULATE
>>> build/ARM/arch/arm/linux/linux.hh:353:27: note: 'TGT_MAP_POPULATE'
>>> declared here
>>> static const unsigned TGT_MAP_POPULATE = 0x08000;
>>>
>>> IMPORTANT NOTICE: The contents of this email and any attachments are
>>> confidential and may also be privileged. If you are not the intended
>>> recipient, please notify the sender immediately and do not disclose the
>>> contents to any other person, use it for any purpose, or store or copy
>>>the
>>> information in any medium. Thank you.
>>> _______________________________________________
>>> gem5-dev mailing list
>>> gem5-dev@gem5.org
>>> http://m5sim.org/mailman/listinfo/gem5-dev
>>>
>>
>_______________________________________________
>gem5-dev mailing list
>gem5-dev@gem5.org
>http://m5sim.org/mailman/listinfo/gem5-dev
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
