-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3381/#review8111
-----------------------------------------------------------

Ship it!


Looks reasonable to me.

- Steve Reinhardt


On March 16, 2016, 4:40 a.m., Andreas Sandberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3381/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 4:40 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 11372:7e2ce7c38e0d
> ---------------------------
> scons, style: Rename style.py to hgstyle.py
> 
> The Mercurial style checker extensions are currently stored in
> style.py. This is not ideal since they won't work with other version
> control systems. This changeset renames style.py to hgstyle.py and
> adds upgrade code to scons that automatically updates the hooks in
> hgrc.
> 
> Signed-off-by: Andreas Sandberg <[email protected]>
> Reviewed-by: Nikos Nikoleris <[email protected]>
> Reviewed-by: Curtis Dunham <[email protected]>
> Reviewed-by: Nathanael Premillieu <[email protected]>
> 
> 
> Diffs
> -----
> 
>   SConstruct af870035ab6b 
>   util/hgstyle.py PRE-CREATION 
>   util/style.py af870035ab6b 
> 
> Diff: http://reviews.gem5.org/r/3381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sandberg
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to