----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3386/#review8116 -----------------------------------------------------------
SConstruct (line 296) <http://reviews.gem5.org/r/3386/#comment6990> For consistency, how about this: style_message = """ You're missing the gem5 style hook, which automatically checks your code against the gem5 style rules when committing changes. This script will now install the hook in your %s. Press enter to continue, or ctrl-c to abort: """ mercurial_style_message = style_message % ".hg/hgrc file" git_style_message = style_message % ".git/hooks/ directory" SConstruct (line 303) <http://reviews.gem5.org/r/3386/#comment6991> this comment should be refactored to better match the new code structure - Steve Reinhardt On March 16, 2016, 4:43 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3386/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 4:43 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11377:62aed3e0d1d3 > --------------------------- > scons: Automatically install the git style hook > > Add a check in the main SConscript that installs the git pre-commit > hook in util/ if git is used. > > Signed-off-by: Andreas Sandberg <[email protected]> > Reviewed-by: Curtis Dunham <[email protected]> > > > Diffs > ----- > > SConstruct af870035ab6b > > Diff: http://reviews.gem5.org/r/3386/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
