Hi Jason, I have tried to make sure that there is as little disruption as possible. The SConstruct file will by default try to rename the hook in .hg/hgrc and should cope with simple modifications. However, this is likely to fail if the hooks or extensions section have been heavily modified.
For most users, the only visible impact will be that SCons asks you if you want to update your hooks configuration. If you’re OK with that, it saves your old configuration and generates a new one with the new hook. //Andreas On 24/03/2016, 19:46, "gem5-dev on behalf of Jason Lowe-Power" <[email protected] on behalf of [email protected]> wrote: >Hi Andreas, > >What's the potential intrusion here? Said another way, will I even notice >if this gets checked in? > >Might you need to add something to the SConscript to modify the .hg/hgrc >with the new path? (That's how the style checker is added currently, >right?) > >Thanks, >Jason > >On Wed, Mar 23, 2016 at 5:15 PM Andreas Sandberg ><[email protected]> >wrote: > >> Hi Everyone, >> >> This is a friendly reminder that RB3381[1] has been on the review system >> for about a week. It is potentially intrusive as it renames the >>Mercurial >> style checker hook. This is in preparation for the new style checker >>that >> supports both git and Mercurial (see previous email). >> >> I would really appreciate it if affected parties could have a look >>before >> mid next week. I¹d like to push this patch fairly soon to be able to >>push >> a final version to our git integration branch and avoid having to rename >> the script twice. >> >> Thanks, >> Andreas >> >> http://reviews.gem5.org/r/3381/ >> >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy >>the >> information in any medium. Thank you. >> >> _______________________________________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/gem5-dev >> >-- > >Jason >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
