> On March 24, 2016, 9 p.m., Steve Reinhardt wrote: > > Do the "validators" do anything the "verifiers" don't? If the only usage > > of the validators is when people manually type 'hg m5format' (which I never > > do), and the validators don't include any additional checks, then I'd be > > fine with just getting rid of them. > > > > On closer inspection, the one thing validate() currently checks that the > > verifiers don't is whether the file has any carriage returns (i.e., > > DOS-format files). If we added that to the Whitespace verifier then I > > think the coverage would be a superset. > > Andreas Sandberg wrote: > I'll add that as a couple of separate patches. One to ad a CR verifier > and one to kill m5format. It'll be a patch after this one though since the > patch now lives in the outgoing Mercurial flow and rebasing is a bit of a > pain.
Sounds good, thanks! - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3383/#review8113 ----------------------------------------------------------- On March 16, 2016, 4:42 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3383/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 4:42 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11374:e2a7d111ec6e > --------------------------- > style: Refactor the style checker as a Python package > > Refactor the style checker into a Python module that can be reused by > command line tools that integrate with git. In particular: > > * Create a style package in util > * Move style validators from style.py to the style/validators.py. > * Move style verifiers from style.py to the style/verifiers.py. > * Move utility functions (sort_includes, region handling, > file_types) into the style package > * Move generic code from style.py to style/style.py. > > Signed-off-by: Andreas Sandberg <[email protected]> > Reviewed-by: Curtis Dunham <[email protected]> > > > Diffs > ----- > > src/python/m5/util/__init__.py af870035ab6b > src/python/m5/util/region.py af870035ab6b > util/file_types.py af870035ab6b > util/hgstyle.py PRE-CREATION > util/sort_includes.py af870035ab6b > util/style/__init__.py PRE-CREATION > util/style/file_types.py PRE-CREATION > util/style/region.py PRE-CREATION > util/style/sort_includes.py PRE-CREATION > util/style/style.py PRE-CREATION > util/style/validators.py PRE-CREATION > util/style/verifiers.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3383/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
