Sounds good. I’ll post a patch. //Andreas
On 24/03/2016, 13:36, "gem5-dev on behalf of Steve Reinhardt" <[email protected] on behalf of [email protected]> wrote: >Yes, we're good with 79. I was offering up the two-char old-school diff >prefix as the probably reasoning for the historical choice of 78, not a >personal argument for keeping it. Sorry for not being clear on that. > >Steve > > >On Thu, Mar 24, 2016 at 3:36 AM Andreas Hansson <[email protected]> >wrote: > >> Hi Steve, >> >> I would suggest we settle for 79 even though that is not entirely diff >> friendly. The main reason is that 80 char is still quite skimp (in this >> day and age) and optimising for editing seems like the right solution. >> >> Andreas >> >> On 16/03/2016, 09:48, "gem5-dev on behalf of Steve Reinhardt" >> <[email protected] on behalf of [email protected]> wrote: >> >> >Off the top of my head, I'd say the effective 77-char restriction is >>just >> >a >> >bug due to not considering the newline char. >> > >> >The motivation for <80 char is so that you can look at diffs/patches >>in an >> >80-char window without wrapping. If you only ever use context diffs, >>then >> >a 79-char limit would be sufficient, but for normal diffs ('> '/'< ' >> >prefix) then it needs to be 78. I don't think it has anything to do >>with >> >emacs. >> > >> >Steve >> > >> >On Wed, Mar 16, 2016 at 9:22 AM Andreas Sandberg >> ><[email protected]> >> >wrote: >> > >> >> Hi Everyone, >> >> >> >> I recently noticed that the style checker forces lines to be 77 >> >>characters >> >> or shorter and not 78 characters. This is presumably caused by the >> >>checker >> >> not stripping the newline character from the line when calculating >>the >> >> length. Is this intentional? The style guide seems to mandate 78 >> >> characters or less. >> >> >> >> I¹d also like to know what the reasoning behind 78 characters and >>why it >> >> isn¹t 80 characters. If it¹s about control characters (e.g., Emacs¹s >> >>line >> >> continuation character), 79 characters should work equally well. >>Judging >> >> by the code in validate() in style.py, the style guide used to >>mandate >> >>79 >> >> characters or less (excluding newline). >> >> >> >> //Andreas >> >> >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> >> confidential and may also be privileged. If you are not the intended >> >> recipient, please notify the sender immediately and do not disclose >>the >> >> contents to any other person, use it for any purpose, or store or >>copy >> >>the >> >> information in any medium. Thank you. >> >> >> >> _______________________________________________ >> >> gem5-dev mailing list >> >> [email protected] >> >> http://m5sim.org/mailman/listinfo/gem5-dev >> >> >> >_______________________________________________ >> >gem5-dev mailing list >> >[email protected] >> >http://m5sim.org/mailman/listinfo/gem5-dev >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy >>the >> information in any medium. Thank you. >> _______________________________________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/gem5-dev >> >_______________________________________________ >gem5-dev mailing list >[email protected] >http://m5sim.org/mailman/listinfo/gem5-dev IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
