----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3402/#review8126 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On March 26, 2016, 3:40 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3402/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 3:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11397:fb4236cf133d > --------------------------- > syscall_emul: factor out flag tables into common file > > The openFlagTable and mmapFlagTables for emulated Linux > platforms are basically identical, but are specified > repetitively for every platform. Use a common file > that gets included for each platform so that we only > have one copy, making them more consistent and simplifying > changes (like adding #ifdefs). > > In the process, made some minor fixes that slipped through > due to previous inconsistencies, and added more #ifdefs > to try to fix building on alternative hosts. > > > Diffs > ----- > > src/arch/alpha/linux/linux.cc ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/arm/linux/linux.cc ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/mips/linux/linux.hh ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/mips/linux/linux.cc ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/power/linux/linux.cc ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/sparc/linux/linux.hh ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/sparc/linux/linux.cc ddfc7795d8f872d193e2dc4b35592223388c66be > src/arch/x86/linux/linux.cc ddfc7795d8f872d193e2dc4b35592223388c66be > src/kern/linux/flag_tables.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/3402/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
