----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3409/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11413:2c9b125d5a42 --------------------------- dev: Fix incorrect terminal backlog handling The Terminal device currently uses the peek functionality in gem5's circular buffer implementation to send existing buffered content on the terminal when a new client attaches. This functionallity is however not implemented correctly and re-sends the same block multiple time. Add the required functionality to peek with an offset into the circular buffer and change the Terminal::accept() implementation to send the buffered contents. Signed-off-by: Andreas Sandberg <[email protected]> Reviewed-by: Radhika Jagtap <[email protected]> Reviewed-by: Nikos Nikoleris <[email protected]> Diffs ----- src/base/circlebuf.hh 1f92ce16e171 src/dev/terminal.cc 1f92ce16e171 Diff: http://reviews.gem5.org/r/3409/diff/ Testing ------- Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
