-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3417/
-----------------------------------------------------------

Review request for Default.


Repository: gem5


Description
-------

Changeset 11419:9f0dee0a0669
---------------------------
ruby: use ENTRY* instead of ENTRY for TBETable

We need to provide the TBE with the size of a cache block so that it
can allocate a data block of that size. But it is not possible to do so
while the TBE is being constructed since SLICC does not allow defining
constructors with arguments.

So, the function that allocates an entry in the TBETable cannot assign it
since that would call on the assignment operator on the DataBlock which will
try to copy data from an unallocated data buffer to an unallocated data
buffer. We avoid this call to the assignment operator for the DataBlock by
using ENTRY* in TBETable.


Diffs
-----

  src/mem/ruby/structures/TBETable.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca 

Diff: http://reviews.gem5.org/r/3417/diff/


Testing
-------


Thanks,

Brandon Potter

_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to