> On April 6, 2016, 9:37 p.m., Andreas Hansson wrote: > > How is that logically possible? Doesn't that suggest something is > > fundamentally wrong? > > Brandon Potter wrote: > I need to reproduce this problem and reconfirm how I arrived at this > solution. I felt confident enough to explain this until I looked at the > flexible Garnet version after your comment and realized that it has the while > condition still. This does solve my problem (or at least hides it), but it > might not be the correct solution. > > The problem (that this patch is supposed to solve) manifested as a > virtual network ordering problem where the ordering was not maintained when > the messages were sent to Garnet. The packets were flitisized on the same > tick and arrived at their destination in the wrong order. Mayhem ensued. > > I'll comment on this again in the next few days. > > Brad Beckmann wrote: > Brandon, I believe this solution was a result of deep technical > discussion with Prod. Tushar Krishna. This is not because something is > "fundatmentally wrong". > > Andreas would you like us to forward that discussion to you?
Just some intuition would be great. Clearly in the hardware implementation the interface can only be used by a single flit at a time... - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3443/#review8150 ----------------------------------------------------------- On April 4, 2016, 11:45 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3443/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11445:dbd48c6aca20 > --------------------------- > garnet: fix bug where multiple enqueues happen on same tick > > > Diffs > ----- > > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3443/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
