> On April 11, 2016, 3:58 p.m., Jason Lowe-Power wrote: > > Seems reasonable to me, but I'd like to see how it's used before I "Ship > > It".
There is one example in this patch already, and I just posted a refinement that makes it even more explicit: http://reviews.gem5.org/r/3445/ - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3444/#review8169 ----------------------------------------------------------- On April 9, 2016, 4:21 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3444/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 4:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11444:42bfea9c43da > --------------------------- > mem: Add a FromCache packet attribute > > This patch adds a FromCache attribute to the packet, and updates a > number of the existing request commands to reflect that the request > originates from a cache. The attribute simplifies checking if a > requests came from a cache or not, and this is used by both the cache > and snoop filter in follow-on patches. > > > Diffs > ----- > > src/mem/cache/cache.cc 0edcf757b6a2 > src/mem/packet.hh 0edcf757b6a2 > src/mem/packet.cc 0edcf757b6a2 > > Diff: http://reviews.gem5.org/r/3444/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
