> On April 11, 2016, 7:08 p.m., Jason Lowe-Power wrote: > > From what I can tell this affect *only* the ruby tester. Is this true?
Yes, it only affects the ruby tester. Everything that referenced the SubBlock class is contained in this patch; with the patch applied, there's no SubBlock in the gem5 source anymore. - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3419/#review8173 ----------------------------------------------------------- On April 4, 2016, 11:39 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3419/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:39 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11421:004c06dd157a > --------------------------- > ruby: remove the SubBlock class > > The SubBlock class was added with AMD's recent GPU patches. However, it does > not provide anything new that the DataBlock class does not already provide > so we remove it here. > > The change requires tracking the address for the DataBlock more closely > and a few new parameters in a couple of functions. > > > Diffs > ----- > > src/cpu/testers/directedtest/RubyDirectedTester.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/directedtest/SConscript > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/Check.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/Check.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/RubyTester.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/RubyTester.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/SConscript > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/cache/tags/base_set_assoc.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/cache/tags/fa_lru.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/common/SConscript cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/common/SubBlock.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/common/SubBlock.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/GPUCoalescer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/Sequencer.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/VIPERCoalescer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3419/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
