> On April 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > Could you explain why? > > > > In general, for all of these patches, could you please add a brief > > description of the "why"? > > Brandon Potter wrote: > The diatribe that I just posted on http://reviews.gem5.org/r/3428/ should > give enough insight into why we need to modify the stats framework. Again, > somebody decided to use statics to aggregate statistics acrosss a controller > type and the result is that it doesn't work for multiple systems. > > Nilay wrote this code which allows the controller statistics to be > aggregated per system at the end of a simulation. > > Andreas Hansson wrote: > I appreciate the "per system" aspect, but what does that have to do with > printing text output? I am somehow not seeing the connection. > > Brandon Potter wrote: > This patch is a preliminary patch that allows the use of the "visit" > method here: http://reviews.gem5.org/r/3431/diff/1/#index_header. It might > have been better to have merged the two patches before posting, but I left > the patches as they were when I received them from Nilay. > > Would you like to see the patches merged so that the purpose of visit() > here is clear within the context of what I'm trying to do with the "per > system" code?
Please do. Right now this change seems very random. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3432/#review8151 ----------------------------------------------------------- On April 4, 2016, 11:43 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3432/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:43 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11434:859f55d0928e > --------------------------- > base: stats: add function for printing text to output > > This patch overloads the function visit() associated with Output class so that > one can output a string. > > > Diffs > ----- > > src/base/stats/info.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/base/stats/output.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/base/stats/text.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/base/stats/text.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3432/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
