> On April 11, 2016, 8:30 p.m., Jason Lowe-Power wrote: > > src/gpu-compute/GPU.py, line 157 > > <http://reviews.gem5.org/r/3421/diff/1/?file=54289#file54289line157> > > > > Get this from the a parent? (See Tags.py) > > > > # Get the block size from the parent (system) > > block_size = Param.Int(Parent.cache_line_size, "block size in > > bytes")
This is a nice catch; nice way to pass in the value rather than having it hard coded as it is now. I'll fix this. > On April 11, 2016, 8:30 p.m., Jason Lowe-Power wrote: > > src/mem/protocol/MOESI_CMP_token-L1cache.sm, line 200 > > <http://reviews.gem5.org/r/3421/diff/1/?file=54295#file54295line200> > > > > Do all of these similar lines need to be update too? This is resolved in http://reviews.gem5.org/r/3430/. - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3421/#review8175 ----------------------------------------------------------- On April 4, 2016, 11:40 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3421/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:40 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11423:41c966b4e307 > --------------------------- > ruby: add a couple of members to ruby objects to remove statics > > The block_size_bits and block_size_bytes members are added to all of the > ruby objects which previously relied on their respective 'RubySystem::' > variants. The goal is to pass in the values through Python parameter lists > and inheritance rather than rely on global variables to pass values. > > This changeset does not modify the functions and methods to use the > the new members; that will happen in subsequent changesets with the goal of > providing some clarity to the new changes rather than a large indecipherable > changeset. > > > Diffs > ----- > > src/mem/ruby/filters/BulkBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/BulkBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/H3BloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/H3BloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/LSB_CountingBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/RubySlicc_Defines.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/AbstractBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/AbstractBloomFilter.cc PRE-CREATION > src/mem/ruby/filters/BlockBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/BlockBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/MultiGrainBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/MultiGrainBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/NonCountingBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/NonCountingBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/SConscript cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/Network.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/LSB_CountingBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/MultiBitSelBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/MultiBitSelBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/Check.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/Check.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/CheckTable.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/CheckTable.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/RubyTester.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/RubyTester.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/cpu/testers/rubytest/RubyTester.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/gpu-compute/GPU.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/gpu-compute/fetch_unit.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/gpu-compute/fetch_unit.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/gpu-compute/shader.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/gpu-compute/shader.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_CMP_directory-L2cache.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_CMP_token-L1cache.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_CMP_token-L2cache.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_CMP_token-dir.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/Sequencer.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/Sequencer.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/VIPERCoalescer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/profiler/Profiler.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/profiler/Profiler.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/AbstractController.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/AbstractController.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/Controller.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/RubyRequest.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/CacheMemory.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/CacheMemory.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/DirectoryMemory.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/DirectoryMemory.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/DirectoryMemory.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/PerfectCacheMemory.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/PersistentTable.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/PersistentTable.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/Prefetcher.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/Prefetcher.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/RubyCache.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/RubyPrefetcher.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/CacheRecorder.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/CacheRecorder.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/GPUCoalescer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubyPort.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubyPort.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubySystem.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3421/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
