Hi Andreas,

This checkin recently made it downstream to our internal repo and I notice that 
you've added a SequenceMatcher with the autojunk parameter. Currently gem5 
claims to require python 2.5-2.7 (http://www.m5sim.org/Dependencies). However, 
adding this parameter now requires 
python2.7.1-2.7.11(https://docs.python.org/2/library/difflib.html) and thus the 
style checker breaks whenever it is run on our system(python2.7).

Could you update the style checker script to use calls that are supported by 
python2.5-2.7.11? We would appreciate it and can then re-enable the style 
checker. Thanks! 

Joe

-----Original Message-----
From: gem5-dev [mailto:[email protected]] On Behalf Of Andreas Sandberg
Sent: Wednesday, March 30, 2016 10:23 AM
To: [email protected]
Subject: [gem5-dev] changeset in gem5: misc: Don't build region.py as a PySource

changeset 1f92ce16e171 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=1f92ce16e171
description:
        misc: Don't build region.py as a PySource

        The style refactor change (style: Refactor the style checker as a
        Python package) moved region.py from src/python/m5/util/ to
        util/style/. The SConscript update accidentally got lost in that
        commit. This commit removes region.py from src/python/SConscript.

        Signed-off-by: Andreas Sandberg <[email protected]>

diffstat:

 src/python/SConscript |  1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diffs (11 lines):

diff -r 2201a8c86538 -r 1f92ce16e171 src/python/SConscript
--- a/src/python/SConscript     Wed Mar 30 15:56:02 2016 +0100
+++ b/src/python/SConscript     Wed Mar 30 16:21:27 2016 +0100
@@ -59,7 +59,6 @@
 PySource('m5.util', 'm5/util/jobfile.py')
 PySource('m5.util', 'm5/util/multidict.py')
 PySource('m5.util', 'm5/util/orderdict.py')
-PySource('m5.util', 'm5/util/region.py')
 PySource('m5.util', 'm5/util/smartdict.py')
 PySource('m5.util', 'm5/util/sorteddict.py')
 PySource('m5.util', 'm5/util/terminal.py')
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to