----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3475/#review8327 -----------------------------------------------------------
Ship it! LGTM. Minor note below. src/sim/simulate.cc (line 91) <http://reviews.gem5.org/r/3475/#comment7206> It might be safer to use an initial PID that will definitely not be a valid PID (e.g. -1) rather than 0, which is a valid PID (just unlikely that it would ever be used for a user process). - Joel Hestness On May 20, 2016, 10:11 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3475/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 10:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11483:d7066cc30459 > --------------------------- > sim: Fix fork for multithreaded simulations > > Previously, when forking, the thread states were inconsistent. > Now, after a fork, we re-create all the needed threads. > This allows you to run in *single-threaded* mode after a fork. > There would need to be a way to migrate the threads to conintue > in threaded mode. > > > Diffs > ----- > > src/sim/simulate.cc fc247b9c42b6 > > Diff: http://reviews.gem5.org/r/3475/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
