----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3448/#review8395 -----------------------------------------------------------
Looks good. Two questions: First, how about the compile-time constants through #defines. Is there a way we can make these run-time configurable? The cacheline size is one prime example. Second, there still appears to be files without a license header. ext/mc2lib/contrib/mcversi/m5_host_support.h (line 44) <http://reviews.gem5.org/r/3448/#comment7267> Is there any way we could make these non-compile time constants? Ultimately it would be good if all of these was parameters for the wrapper. ext/mc2lib/contrib/mcversi/m5_host_support.h (line 89) <http://reviews.gem5.org/r/3448/#comment7269> does x86 support flushing? both classic and ruby? ext/mc2lib/contrib/mcversi/m5_host_support.h (line 124) <http://reviews.gem5.org/r/3448/#comment7268> should we just get it done rather? ext/mc2lib/contrib/mcversi/run-10-8KB.sh (line 1) <http://reviews.gem5.org/r/3448/#comment7270> Technically all of these need a license header. - Andreas Hansson On June 4, 2016, 12:23 p.m., Marco Elver wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3448/ > ----------------------------------------------------------- > > (Updated June 4, 2016, 12:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Add mc2lib to ext/ > > This is the simulator-independent component for McVerSi. > > Source: https://github.com/melver/mc2lib > > > Diffs > ----- > > ext/mc2lib/include/mc2lib/types.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/ops/x86_64.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/rit.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/mcversi.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/memconsistency/cats.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/memconsistency/eventsets.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/memconsistency/model12.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/sets.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/simplega.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/ops/strong.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/compiler.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/ops/armv7.hpp PRE-CREATION > SConstruct e18a6c55bec0 > ext/mc2lib/LICENSE PRE-CREATION > ext/mc2lib/README.rst PRE-CREATION > ext/mc2lib/SConscript PRE-CREATION > ext/mc2lib/_UPSTREAM PRE-CREATION > ext/mc2lib/contrib/mcversi/README.rst PRE-CREATION > ext/mc2lib/contrib/mcversi/guest_workload.c PRE-CREATION > ext/mc2lib/contrib/mcversi/host_support.h PRE-CREATION > ext/mc2lib/contrib/mcversi/m5_host_support.h PRE-CREATION > ext/mc2lib/contrib/mcversi/run-10-8KB-1synonym.sh PRE-CREATION > ext/mc2lib/contrib/mcversi/run-10-8KB.sh PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/cats.hpp PRE-CREATION > > Diff: http://reviews.gem5.org/r/3448/diff/ > > > Testing > ------- > > Together with http://reviews.gem5.org/r/3449/ > > > Thanks, > > Marco Elver > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
