Hi, so what is the usual process of getting patches in? So far, I have a "ship it" from one reviewer. Do I need more? If yes, can someone please have a look? If not, how do we proceed from here? Btw, I don't think this is documented anywhere.
Thanks, Jakub On 06/13/2016 10:27 AM, Jakub Jermar wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3503/ > > > Review request for Default. > By Jakub Jermar. > *Repository: * gem5 > > > Description > > At the moment the SPARC FS machine configuration comes with a hardcoded > value for using the Solaris 10 disk image from the OpenSPARC tarball. > The --disk-image option is completely ignored for SPARC. This simple > patch modifies the behavior so that --disk-image option is both taken > into account and also required. This makes it possible to easily change > SPARC FS images without having to modify the configuration files. > > > Testing > > * successfully ran SPARC FS simulation with --disk-image pointed to a > HelenOS ISO image > * successfully ran SPARC FS simulation with --disk-image pointed to > the Solaris 10 image from the OpenSPARC tarball > * verified that not specifying a --disk-image option results in a > sensible error message > > > Diffs > > * configs/common/FSConfig.py (a22c4bac7e15) > > View Diff <http://reviews.gem5.org/r/3503/diff/> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
