-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3374/#review8423
-----------------------------------------------------------



configs/example/hmctest.py (lines 35 - 38)
<http://reviews.gem5.org/r/3374/#comment7295>

    How about making the arch also more readable: type = string, choices = 
'same', 'distributed', 'mix-same-dist'? Will be much  better for readability, 
debugging, hackability..



configs/example/hmctest.py (lines 99 - 117)
<http://reviews.gem5.org/r/3374/#comment7294>

    Can you make the mem ranges more readable and in a loop (e.g. 256 * 1024 * 
1024)?



configs/example/hmctest.py (lines 129 - 142)
<http://reviews.gem5.org/r/3374/#comment7296>

    Same here, can you make the mem ranges more readable?


- Radhika Jagtap


On June 19, 2016, 10:37 p.m., Abdul Mutaal Ahmad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3374/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 10:37 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> This patch provides the example test script to configure different HMC 
> architecture and run traffic through traffic generator.
> 
> 
> Diffs
> -----
> 
>   configs/example/hmctest.py PRE-CREATION 
>   tests/quick/se/70.tgen/traffic.cfg PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3374/diff/
> 
> 
> Testing
> -------
> 
> To run, it requires the main HMC config patch 
> 
> http://reviews.gem5.org/r/3373/
> 
> ===============
> How to run it
> ===============
> from you gem5 home directory run the following commands
> 
> build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 
> --mode=RANDOM  --arch=0
> build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 
> --mode=RANDOM  --arch=1
> build/ARM/gem5.opt configs/example/hmctest.py --mem-type=HMC_2500_x32 
> --mode=RANDOM  --arch=2
> 
> 
> Thanks,
> 
> Abdul Mutaal Ahmad
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to