> On June 26, 2016, 9:59 p.m., Andreas Hansson wrote: > > I realise I am commenting on DRAMPower changes here, so feel free to ignore. > > > > There seems to be an awful lot of changes from unsigned to signed types, > > which feels rather unintuitive. Why not uint64_t if the value is truly > > unsigned? It seems odd to remove that clear communication of intent. > > > > There also seems to be quite a few static_cast<size_t> cause by the above > > change, which clutters the code. If the bank, for example, is unsigned this > > should not be needed. > > Matthias Jung wrote: > there where some discussions about that issue in DRAMPowers git repro: > > https://github.com/ravenrd/DRAMPower/issues/10#issuecomment-207067743
I am not against updating, but some of these style issues would be good to get resolved as even clang and gcc complain. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3525/#review8438 ----------------------------------------------------------- On June 22, 2016, 7:52 p.m., Matthias Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3525/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 7:52 p.m.) > > > Review request for Default and Andreas Sandberg. > > > Repository: gem5 > > > Description > ------- > > Sync DRAMPower to external tool > > This patch syncs the DRAMPower library of gem5 to the external > one on github (https://github.com/ravenrd/DRAMPower) of which > I am a maintainer. > > The version used is the commit: > 902a00a1797c48a9df97ec88868f20e847680ae6 > from 07. May. 2016. > > > Diffs > ----- > > ext/drampower/README.md dd6dfd38b6c2 > ext/drampower/src/CmdScheduler.h dd6dfd38b6c2 > ext/drampower/src/CmdScheduler.cc dd6dfd38b6c2 > ext/drampower/src/CommandAnalysis.h dd6dfd38b6c2 > ext/drampower/src/CommandAnalysis.cc dd6dfd38b6c2 > ext/drampower/src/MemArchitectureSpec.h dd6dfd38b6c2 > ext/drampower/src/MemCommand.h dd6dfd38b6c2 > ext/drampower/src/MemCommand.cc dd6dfd38b6c2 > ext/drampower/src/MemTimingSpec.h dd6dfd38b6c2 > ext/drampower/src/MemoryPowerModel.h dd6dfd38b6c2 > ext/drampower/src/MemoryPowerModel.cc dd6dfd38b6c2 > ext/drampower/src/MemorySpecification.h dd6dfd38b6c2 > ext/drampower/src/TraceParser.h dd6dfd38b6c2 > ext/drampower/src/TraceParser.cc dd6dfd38b6c2 > ext/drampower/src/Utils.h dd6dfd38b6c2 > ext/drampower/src/libdrampower/LibDRAMPower.h dd6dfd38b6c2 > ext/drampower/src/libdrampower/LibDRAMPower.cc dd6dfd38b6c2 > ext/drampower/test/libdrampowertest/lib_test.cc dd6dfd38b6c2 > src/mem/dram_ctrl.hh dd6dfd38b6c2 > > Diff: http://reviews.gem5.org/r/3525/diff/ > > > Testing > ------- > > Everything compiles. > > > Thanks, > > Matthias Jung > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
