Thanks for sorting this out! We need to streamline this flow sooner rather than later, but that's a different question.
Cheers, Andreas On 30/06/2016, 15:19, "Jason Lowe-Power" <[email protected]<mailto:[email protected]>> wrote: Tomorrow, I'm planning on checking in the following patches. Let me know if anyone has any objections. They've all either gotten multiple "Ship Its" or have been on reviewboard for a while (with reviews+changes). @Matthias, Abdul, Andreas H., let me know if I'm missing any patches I should push or if I have them in the wrong order (I'm going with the order they were posted to reviewboard). On a side note, in the future, it would be good if the patch submitters would make sure that whatever is in the description on reviewboard is formatted correctly. Whenever I download the patches from reviewboard it doesn't come with the commit information, so I have to copy and paste it for each patch. Having to also manually format it is a pain. Thanks! http://reviews.gem5.org/r/3132/ http://reviews.gem5.org/r/3373/ http://reviews.gem5.org/r/3374/ http://reviews.gem5.org/r/3473/ http://reviews.gem5.org/r/3477/ http://reviews.gem5.org/r/3525/ Cheers, Jason On Thu, Jun 30, 2016 at 5:23 AM Abdul Mutaal Ahmad <[email protected]<mailto:[email protected]>> wrote: Hi, Matthias I think you forgot to mention the 'stats' patch. This patch is also reviewed and there are no open issues. http://reviews.gem5.org/r/3132/ Thanks Best Regards, Abdul Mutaal University of Kaiserslautern https://www.linkedin.com/in/abdulmutaalahmad -----Original Message----- From: Matthias Jung [mailto:[email protected]<mailto:[email protected]>] Sent: Thursday, June 30, 2016 11:19 AM To: Jason Lowe-Power; Andreas Sandberg Cc: Christian Menard; Abdul Mutaal Ahmad Subject: Re: Gem5 Patches Sorry I forgot also to mention my update to DRAMPower library: http://reviews.gem5.org/r/3525/ > Am 30.06.2016 um 11:17 schrieb Matthias Jung > <[email protected]<mailto:[email protected]>>: > > Hi Jason and Andreas, > > is there a chance that you could push the following changes? > > Especially this one will be presented in some days on the SAMOS conference: > > http://reviews.gem5.org/r/3477/ > > I think many people will be interested in that, so it would be nice if we > could just tell them its already part of gem5. > > There is a small fix: > > http://reviews.gem5.org/r/3473/ > > And here are two patches regarding HMC, which are reviewed and could be > pushed too: > > http://reviews.gem5.org/r/3373/ > http://reviews.gem5.org/r/3374/ > > Thank you and regards > Matthias > > > -- > > Dipl.-Ing. Matthias Jung > > Member > Advanced Silicon Technologies & Design Methodologies > > > University of Kaiserslautern > Microelectronic Systems Design Research Group > Erwin-Schrödinger-Straße 12/228 > 67663 Kaiserslautern, Germany > > Phone: +49 631 205 3579 > Fax: +49 631 205 4437 > [email protected]<mailto:[email protected]> > http://ems.eit.uni-kl.de > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
