----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3562/#review8491 -----------------------------------------------------------
Ship it! Ship It! - Tony Gutierrez On July 12, 2016, 12:15 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3562/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 12:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11564:76718cb08673 > --------------------------- > mem: Use FromCache attribute in snoop filter allocation > > This patch improves the snoop filter allocation decisions by not only > looking at whether a port is snooping or not, but also if the packet > actually came from a cache. The issue with only looking at isSnooping > is that the CPU ports, for example, are snooping, but not actually > caching. Previously we ended up incorrectly allocating entries in > systems without caches (such as the atomic and timing quick > regressions). Eventually these misguided allocations caused the snoop > filter to panic due to an excessive size. > > On the request path we now include the fromCache check on the packet > itself, and for responses we check if we actually have a snoop-filter > entry. > > Change-Id: Idd2dbc4f00c7e07d331e9a02658aee30d0350d7e > Reviewed-by: Nikos Nikoleris <[email protected]> > Reviewed-by: Stephan Diestelhorst <[email protected]> > > > Diffs > ----- > > src/mem/snoop_filter.cc f050b8cf4754 > > Diff: http://reviews.gem5.org/r/3562/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
